On 12/06/2016 04:10 PM, Max Reitz wrote: > On 02.12.2016 20:22, Eric Blake wrote: >> Rather than store into a local variable, the copy to the struct >> if the value is valid, then reporting errors otherwise, > > It is rather difficult to part this sentence starting from "the copy".
That's because I meant to type "then copy". (What a difference an 'n' makes - I hope it does't imply that the batteries i my wireless keyboard are o the declie agai, or a sig of ay other more serious problem) > >> it is >> simpler to just store into the struct and report errors if the >> value is invalid. This however requires that the struct store >> a 64-bit number, rather than a narrower type. >> >> Signed-off-by: Eric Blake <ebl...@redhat.com> >> >> --- >> v3: new patch >> --- >> block/blkdebug.c | 11 ++++------- >> 1 file changed, 4 insertions(+), 7 deletions(-) > > Anyway, thanks! If you can explain to me how to parse the commit message > or make it easier to read: > > Reviewed-by: Max Reitz <mre...@redhat.com> > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
