Hi Daniel,
On 2016/12/5 17:24, Daniel P. Berrange wrote:
> On Mon, Dec 05, 2016 at 04:59:40PM +0800, Longpeng(Mike) wrote:
......
>> {
>> + .path = "/crypto/cipher/des-ecb",
>> + .alg = QCRYPTO_CIPHER_ALG_DES,
>> + .mode = QCRYPTO_CIPHER_MODE_ECB,
>> + .key =
>> + "0123456789abcdef",
>> + .plaintext =
>> + "0123456789abcde7",
>> + .ciphertext =
>> + "c95744256a5ed31d",
>> + },
>> + {
>> .path = "/crypto/cipher/des-rfb-ecb-56",
>> .alg = QCRYPTO_CIPHER_ALG_DES_RFB,
>> .mode = QCRYPTO_CIPHER_MODE_ECB,
>
> This should be included as part of the patch which adds the cipher
> in the first place. Ideally there should be a CBC mode test as well.
>
Okay.
I will put this in the first patch(which adds the cipher) and add a cbc(aes)
testcase in v2. :)
> Regards,
> Daniel
--
Regards,
Longpeng(Mike)
