On Fri, 12/02 15:33, Max Reitz wrote: > On 02.12.2016 11:40, Laszlo Ersek wrote: > > When passed to git-diff (and to every other git command producing diffs > > and/or diffstats) with "-O" or "diff.orderFile", this list of patterns > > will place the more declarative / abstract hunks first, while changes to > > imperative code / details will be near the end of the patches. This saves > > on scrolling / searching and makes for easier reviewing. > > > > We intend to advise contributors in the Wiki to run > > > > git config diff.orderFile scripts/git.orderfile > > > > once, as part of their initial setup, before formatting their first (or, > > for repeat contributors, next) patches. > > > > See the "-O" option and the "diff.orderFile" configuration variable in > > git-diff(1) and git-config(1). > > > > Cc: "Michael S. Tsirkin" <[email protected]> > > Cc: Eric Blake <[email protected]> > > Cc: Fam Zheng <[email protected]> > > Cc: Gerd Hoffmann <[email protected]> > > Cc: John Snow <[email protected]> > > Cc: Stefan Hajnoczi <[email protected]> > > Signed-off-by: Laszlo Ersek <[email protected]> > > --- > > > > Notes: > > I think I managed to incorporate everyone's feedback! > > > > scripts/git.orderfile | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > create mode 100644 scripts/git.orderfile > > > > diff --git a/scripts/git.orderfile b/scripts/git.orderfile > > new file mode 100644 > > index 000000000000..600a2e4fc540 > > --- /dev/null > > +++ b/scripts/git.orderfile > > @@ -0,0 +1,15 @@ > > +*.txt > > We also have *.md. (OK, OK, we have a single docs/bitmaps.md, but maybe > it's going to be more in the future. :-))
Maybe just insert 'docs/*' here? I'm not sure if it works for the subdirs, though. Fam > > Max > > > +configure > > +GNUmakefile > > +makefile > > +Makefile > > +*.mak > > +qapi-schema*.json > > +qapi/*.json > > +include/qapi/visitor.h > > +include/qapi/visitor-impl.h > > +scripts/qapi.py > > +scripts/*.py > > +*.h > > +qapi/qapi-visit-core.c > > +*.c > > > >
