Hi Alex, I have a merged branch with these changes but it needs more work. I will post the next version soon(for some definition of soon :)
You can find the in-progress branch here: https://github.com/pranith/qemu tcg_test_cleanup_v4 Thanks, On Thu, Nov 3, 2016 at 9:35 AM, Alex Bennée <[email protected]> wrote: > > Marc-André Lureau <[email protected]> writes: > >> Hi >> >> On Mon, Sep 19, 2016 at 7:57 PM Pranith Kumar <[email protected]> wrote: >> >>> >>> Hi Marc, >>> >>> Marc-André Lureau writes: >>> >>> > Hi Pranith >>> > >>> > On Sat, Sep 17, 2016 at 6:05 PM Pranith Kumar <[email protected]> >>> wrote: >>> > >>> >> Hello, >>> >> >>> >> This patch series cleans up the tcg tests in tests/tcg folder. >>> >> >>> >> >>> > Incidentally, I was also looking at reorganizing tests/tcg last week. I >>> > think your series brings some necessary improvements, but it will >>> probably >>> > need more iterations before it is accepted. Could you split off your >>> > obvious changes, such as test build fixes? I think it would help to get >>> > those out of the way first (cc -trivial). Also it would help if you >>> > documented the makefile changes. >>> >>> >> fwiw, here is my wip at cleaning up tests/tcg: >> https://github.com/elmarco/qemu/tree/tcg-tests/tests/tcg >> >> The build-sys there has a lot of benefits over what is in tests/tcg today: >> - uses implicit rules, for building, for running qemu >> - dependency tracking >> - generate gitignore, clean rule >> - detects cross-compiler and qemu, skip the test when unavailable >> >> I have quite a lot of trouble finding suitable cross-compilers for the >> various archs. crosstool-ng helped me to build some of them, but it's not >> obvious how to build the various archs, and when it builds, it often >> fails/crash. Anyway, this can hopefully give some ideas/inspiration. I did >> port i386/x64 and arm, and fixes a couple of qemu bugs on the way. (but arm >> mmap test still crashes qemu for ex). >> >> OK, I will split up the patches into trivial fixes and document the changes >>> to >>> Makefiles. > > Where did we get to with these changes? Who's posting the next series? > > -- > Alex Bennée -- Pranith
