On 10/25/2016 08:04 AM, Ashijeet Acharya wrote: > Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to > support blockdev-add for SSH network protocol driver. Use only 'struct > InetSocketAddress' since SSH only supports connection over TCP. > > Signed-off-by: Ashijeet Acharya <[email protected]> > Reviewed-by: Kevin Wolf <[email protected]> > --- > qapi/block-core.json | 26 ++++++++++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-)
Sorry for not noticing this when I finally replied to v4; > +## > +# @BlockdevOptionsSsh > +# > +# @server: host address > +# > +# @path: path to the image on the host > +# > +# @user: #optional user as which to connect, defaults to > current > +# local user name > +# > +# @host_key_check #optional defines how and what to check the host > +# key against, defaults to "yes" I still have reservations about this parameter. I think we have time to fix it as followups during soft freeze if Kevin would rather get your initial patches in now, if that's what it takes to meet soft freeze deadlines, but I do not want to bake it into the actual 2.8 release without addressing those concerns. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
