On 09/08/2016 10:14 PM, Eric Blake wrote: > It is rather verbose, and slightly error-prone, to repeat > the same set of parameters for input (migrate-set-parameters) > as for output (query-migrate-parameters), where the only > difference is whether the members are optional. We can just > document that the optional members will always be present > on output, and then share a common struct between both > commands. The next patch can then reduce the amount of > code needed on input.
> '*tls-hostname': 'str'} }
> -
> -#
> -# @MigrationParameters
> -#
...
> -##
> -{ 'struct': 'MigrationParameters',
> - 'data': { 'compress-level': 'int',
> - 'compress-threads': 'int',
> - 'decompress-threads': 'int',
> - 'cpu-throttle-initial': 'int',
> - 'cpu-throttle-increment': 'int',
> - 'tls-creds': 'str',
> - 'tls-hostname': 'str'} }
> ##
> # @query-migrate-parameters
Pre-existing - there was no blank line before the docs for
query-migrate-parameters. Commit a43edcf fixed the blank line, then the
merge conflict resolution undid things; so I've submitted a followup.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
