On Fri, Oct 14, 2016 at 03:08:30PM +0200, Igor Mammedov wrote: > On Thu, 13 Oct 2016 18:26:39 -0300 > Eduardo Habkost <[email protected]> wrote: > > > When doing the conversion, the NULL errp arguments on the > > property registration calls were changed to &error_abort. > > > > Signed-off-by: Eduardo Habkost <[email protected]> > So many property registrations look pretty ugly but still > better than doing it per instance, not that it matters > so far as there is only 1 instance of Machine at a time. > > So > Reviewed-by: Igor Mammedov <[email protected]>
Thanks! > > most of the properties below are dumb field setter/getter, > it would be much better to declare them statically and > make generic Object code to initialize them at type > initialization time. > i.e. make similar thing like static properties but for class > and probably extend it to have optional custom setter/getter. I've been considering doing that. It should be easier after the "qdev class properties" series gets applied, but the existing static-property code is still specific to DeviceState (probably it's only because the static property getter/setters include a dev->realized check). -- Eduardo
