Hi,
Your series seems to have some coding style problems. See output below for
more information:
Message-id: 1476107947-31430-1-git-send-email-pbonz...@redhat.com
Subject: [Qemu-devel] [PATCH 0/5] More thread sanitizer fixes and atomic.h
improvements
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/1475847779-7336-1-git-send-email-kw...@redhat.com
-> patchew/1475847779-7336-1-git-send-email-kw...@redhat.com
- [tag update]
patchew/1476099707-526-1-git-send-email-berra...@redhat.com ->
patchew/1476099707-526-1-git-send-email-berra...@redhat.com
* [new tag]
patchew/1476107947-31430-1-git-send-email-pbonz...@redhat.com ->
patchew/1476107947-31430-1-git-send-email-pbonz...@redhat.com
* [new tag]
patchew/1476113163-24578-1-git-send-email-peter.mayd...@linaro.org ->
patchew/1476113163-24578-1-git-send-email-peter.mayd...@linaro.org
* [new tag] patchew/20161010152848.17902-1-rkrc...@redhat.com ->
patchew/20161010152848.17902-1-rkrc...@redhat.com
- [tag update] patchew/cover.1475757437.git.be...@igalia.com ->
patchew/cover.1475757437.git.be...@igalia.com
Switched to a new branch 'test'
8e1cfa9 atomic: base mb_read/mb_set on load-acquire and store-release
5cfb494 rcu: simplify memory barriers
5886ce0 qemu-thread: use acquire/release to clarify semantics of QemuEvent
7a5cb66 cpus: use atomic_read to read seqlock-protected variables
e663e45 atomic: introduce smp_mb_acquire and smp_mb_release
=== OUTPUT BEGIN ===
Checking PATCH 1/5: atomic: introduce smp_mb_acquire and smp_mb_release...
ERROR: line over 90 characters
#195: FILE: include/qemu/atomic.h:75:
+#define smp_mb() ({ barrier();
__atomic_thread_fence(__ATOMIC_SEQ_CST); })
ERROR: memory barrier without comment
#195: FILE: include/qemu/atomic.h:75:
+#define smp_mb() ({ barrier();
__atomic_thread_fence(__ATOMIC_SEQ_CST); })
ERROR: line over 90 characters
#196: FILE: include/qemu/atomic.h:76:
+#define smp_mb_release() ({ barrier();
__atomic_thread_fence(__ATOMIC_RELEASE); })
ERROR: line over 90 characters
#197: FILE: include/qemu/atomic.h:77:
+#define smp_mb_acquire() ({ barrier();
__atomic_thread_fence(__ATOMIC_ACQUIRE); })
ERROR: line over 90 characters
#205: FILE: include/qemu/atomic.h:84:
+#define smp_read_barrier_depends() ({ barrier();
__atomic_thread_fence(__ATOMIC_CONSUME); })
ERROR: memory barrier without comment
#205: FILE: include/qemu/atomic.h:84:
+#define smp_read_barrier_depends() ({ barrier();
__atomic_thread_fence(__ATOMIC_CONSUME); })
ERROR: spaces required around that ':' (ctx:OxW)
#241: FILE: include/qemu/atomic.h:266:
+#define smp_wmb() ({ asm volatile("eieio" ::: "memory"); (void)0; })
^
ERROR: memory barrier without comment
#241: FILE: include/qemu/atomic.h:266:
+#define smp_wmb() ({ asm volatile("eieio" ::: "memory"); (void)0; })
ERROR: spaces required around that ':' (ctx:OxW)
#244: FILE: include/qemu/atomic.h:268:
+#define smp_mb_release() ({ asm volatile("lwsync" ::: "memory"); (void)0; })
^
ERROR: spaces required around that ':' (ctx:OxW)
#245: FILE: include/qemu/atomic.h:269:
+#define smp_mb_acquire() ({ asm volatile("lwsync" ::: "memory"); (void)0; })
^
ERROR: spaces required around that ':' (ctx:OxW)
#248: FILE: include/qemu/atomic.h:271:
+#define smp_mb_release() ({ asm volatile("sync" ::: "memory"); (void)0; })
^
ERROR: spaces required around that ':' (ctx:OxW)
#249: FILE: include/qemu/atomic.h:272:
+#define smp_mb_acquire() ({ asm volatile("sync" ::: "memory"); (void)0; })
^
ERROR: spaces required around that ':' (ctx:OxW)
#252: FILE: include/qemu/atomic.h:274:
+#define smp_mb() ({ asm volatile("sync" ::: "memory"); (void)0; })
^
ERROR: memory barrier without comment
#252: FILE: include/qemu/atomic.h:274:
+#define smp_mb() ({ asm volatile("sync" ::: "memory"); (void)0; })
ERROR: memory barrier without comment
#265: FILE: include/qemu/atomic.h:285:
+#define smp_mb() __sync_synchronize()
ERROR: memory barrier without comment
#303: FILE: include/qemu/atomic.h:411:
+#define smp_wmb() smp_mb_release()
ERROR: memory barrier without comment
#306: FILE: include/qemu/atomic.h:414:
+#define smp_rmb() smp_mb_acquire()
total: 17 errors, 0 warnings, 274 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/5: cpus: use atomic_read to read seqlock-protected variables...
Checking PATCH 3/5: qemu-thread: use acquire/release to clarify semantics of
QemuEvent...
Checking PATCH 4/5: rcu: simplify memory barriers...
Checking PATCH 5/5: atomic: base mb_read/mb_set on load-acquire and
store-release...
WARNING: architecture specific defines should be avoided
#155: FILE: include/qemu/atomic.h:370:
+#if defined(__i386__) || defined(__x86_64__) || defined(__s390x__)
ERROR: memory barrier without comment
#167: FILE: include/qemu/atomic.h:382:
+ smp_mb(); \
ERROR: space required before the open parenthesis '('
#168: FILE: include/qemu/atomic.h:383:
+} while(0)
total: 2 errors, 1 warnings, 142 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
