On 10/10/2016 17:01, Daniel P. Berrange wrote: > On Mon, Oct 10, 2016 at 04:45:56PM +0200, Paolo Bonzini wrote: >> >> >> On 10/10/2016 16:32, Lin Ma wrote: >>>> This doesn't make any conceptual sense. UserCreatable is an inteface and >>>> by definition all interfaces are abstract. >>> >>> Sorry for the late reply, I was on vacation. >>> oh...indeed, add '.abstract = true' for an interface is not a good idea. >> >> Perhaps Lin Ma's patch actually made some sense. If all interfaces are >> abstract, why shouldn't object_class_is_abstract say so? > > object_class_is_abstract() should say so, but we should not have to > express that manually when defining the interface - anything that is > define as an interface should be automatically abstract
Yes, of course, see my suggestion right after that line. :) Paolo
