On 09/29/2016 10:42 PM, Markus Armbruster wrote:
Cao jin <[email protected]> writes:
static int vmxnet3_post_load(void *opaque, int version_id)
{
VMXNET3State *s = opaque;
- PCIDevice *d = PCI_DEVICE(s);
net_tx_pkt_init(&s->tx_pkt, PCI_DEVICE(s),
s->max_tx_frags, s->peer_has_vhdr);
net_rx_pkt_init(&s->rx_pkt, s->peer_has_vhdr);
- if (s->msix_used) {
- if (!vmxnet3_use_msix_vectors(s, VMXNET3_MAX_INTRS)) {
- VMW_WRPRN("Failed to re-use MSI-X vectors");
- msix_uninit(d, &s->msix_bar, &s->msix_bar);
- s->msix_used = false;
- return -1;
- }
- }
-
vmxnet3_validate_queues(s);
vmxnet3_validate_interrupts(s);
This hunk isn't obvious. Can you explain the change?
flag msix_used is used in VMStateDescription.post_Load().
1st, I think msix's code here is not necessary, because in destination,
device has been realized before incoming migration, So I don't know why
re-use MSI-X vectors here. Dmitry, could help to explain?
2nd, this patch is going to remove this flag, so I removed the hunk.
--
Yours Sincerely,
Cao jin
