Am 26.09.2016 um 12:59 hat Paolo Bonzini geschrieben:
> On 22/09/2016 18:29, Kevin Wolf wrote:
> > - qmp_x_blockdev_remove_medium(device, &err);
> > + qmp_x_blockdev_remove_medium(true, device, false, NULL, errp);
> > if (err) {
> > error_propagate(errp, err);
> > goto fail;
>
> Bug: &err changed to errp, so err is always NULL.
&err vs. errp is kind of hard to spot in a diff. Maybe a good reason to
stick with "local_err" rather than "err" where we introduce new local
error variables.
Anyway, patch sent.
Kevin
