On Thu, Sep 15, 2016 at 11:19:09AM -0300, Eduardo Habkost wrote:
> On Wed, Sep 14, 2016 at 12:01:49PM +0200, Igor Mammedov wrote:
> > commit (a4d3c834 pc: Add 2.8 machine) didn't ammend
> > PC_COMPAT_2_6 to include PC_COMPAT_2_7 which results in
> >
> > {\
> > .driver = "virtio-pci",\
> > .property = "page-per-vq",\
> > .value = "on",\
> > },
> >
> > and
> >
> > {\
> > .driver = TYPE_X86_CPU,\
> > .property = "l3-cache",\
> > .value = "off",\
> > },
> >
> > being ignored and as result change PC_COMPAT_2_6 behaviour.
> >
> [...]
> > #define PC_COMPAT_2_6 \
> > + PC_COMPAT_2_7 \
> > HW_COMPAT_2_6 \
> > {\
> > .driver = "fw_cfg_io",\
>
> Isn't this supposed to be unnecessary since commit bacc344c
> ("machine: add properties to compat_props incrementaly")?
>
> --
> Eduardo
Indeed, I tested page-per-vq and it seems on for 2.6.
Igor, Marcel, could you comment pls?
--
MST
