Re: [Qemu-devel] [PATCH v4 2/3] tests: make pc_alloc_init/init_flags/uninit generic

[Laurent Vivier]

On 06/09/2016 23:41, Greg Kurz wrote:
> On Tue,  6 Sep 2016 15:17:56 +0200
> Laurent Vivier <lviv...@redhat.com> wrote:
> 
>> And add support for ppc64.
>>
>> Signed-off-by: Laurent Vivier <lviv...@redhat.com>
>> ---
>> v2:
>> - remove useless parenthesis, inline
>>
> 
> This works indeed but I'm just feeling curious about the QOSOps type 
> introduced
> by the following commit:
> 
> commit 90e5add6f2fa0b0bd9a4c1d5a4de2304b5f3e466
> Author: John Snow <js...@redhat.com>
> Date:   Mon Jan 19 15:15:55 2015 -0500
> 
>     libqos: add pc specific interface
> 
> Wouldn't this be better to implement something similar for ppc64 instead of
> relying on strcmp() ?

Tests can be generic and to be run on several archs: we need the
strcmp() to check the guest arch [1], it can't be hardcoded in the test.

Thanks,
Laurent

[1]
const char *qtest_get_arch(void)
{
    const char *qemu = getenv("QTEST_QEMU_BINARY");
    g_assert(qemu != NULL);
    const char *end = strrchr(qemu, '/');

    return end + strlen("/qemu-system-");
}