On 9 August 2016 at 20:08, Alex Bennée <[email protected]> wrote:
> Squash or move to the position before?

There's not much code here and in any case it assumes
the existence of variables only set in the previous
patch, so I'd just squash.

PS:

>>> +    if test "$cpu_width" = "32"; then
>>> +        case $target in
>>> +            *64*|s390x-*)
>>> +                # skip 64 bit machines

...this is adding another place that's listing all 64-bit
targets and which would need to be changed if we add another
64-bit target in future.

thanks
-- PMM

Reply via email to