On 3 August 2016 at 09:02, Benjamin Herrenschmidt
<[email protected]> wrote:
> Other archs don't do it, some programs catch signals just fine
> and those dumps just clutter the output. Keep the dumps for cases
> that aren't supposed to happen such as unknown codes.
>
> Signed-off-by: Benjamin Herrenschmidt <[email protected]>
> ---
> linux-user/main.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index eb9975c..8fbc5a6 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -1651,9 +1651,6 @@ void cpu_loop(CPUPPCState *env)
> "Aborting\n");
> break;
> case POWERPC_EXCP_DSI: /* Data storage exception
> */
> - EXCP_DUMP(env, "Invalid data memory access: 0x" TARGET_FMT_lx
> "\n",
> - env->spr[SPR_DAR]);
> - /* XXX: check this. Seems bugged */
Are you removing these XXX comments because you've checked the
error code cases below? If so it would be useful to say so
in the commit message...
> switch (env->error_code & 0xFF000000) {
> case 0x40000000:
> case 0x42000000:
> @@ -1684,9 +1681,6 @@ void cpu_loop(CPUPPCState *env)
> queue_signal(env, info.si_signo, &info);
> break;
> case POWERPC_EXCP_ISI: /* Instruction storage exception
> */
> - EXCP_DUMP(env, "Invalid instruction fetch: 0x\n" TARGET_FMT_lx
> - "\n", env->spr[SPR_SRR0]);
> - /* XXX: check this */
> switch (env->error_code & 0xFF000000) {
> case 0x40000000:
> info.si_signo = TARGET_SIGSEGV;
thanks
-- PMM
