On Thu, Jul 28, 2016 at 03:39:30PM +0800, Cao jin wrote: > Fix some coding style issues found in removing NonBlockingConnectHandler. > > Cc: Daniel P. Berrange <[email protected]> > Cc: Gerd Hoffmann <[email protected]> > Cc: Paolo Bonzini <[email protected]> > Signed-off-by: Cao jin <[email protected]> > --- > util/qemu-sockets.c | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-)
Reviwed-by: Daniel P. Berrange <[email protected]> > @@ -443,12 +443,16 @@ static int inet_dgram_saddr(InetSocketAddress *sraddr, > return sock; > > err: > - if (-1 != sock) > + if (-1 != sock) { I'd probably fix the yoda-conditional here too. ie sock != -1 instead. > closesocket(sock); > - if (local) > + } > + if (local) { > freeaddrinfo(local); > - if (peer) > + } > + if (peer) { > freeaddrinfo(peer); > + } > + > return -1; > } Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
