On 12 July 2016 at 00:20, Alistair Francis <[email protected]> wrote:
> Arrayify the Cadence GEM device to prepare for adding priority queue support.
>
> Signed-off-by: Alistair Francis <[email protected]>
> ---
>
> This patch has no real effect, I used it to help debug some issues so I
> figured I would leave it in.
An expanded commit message here would be useful, something along
the lines of the hardware having N priority queues and that
the behaviour doesn't yet change because we only use queue 0,
or whatever. The subject line is also a bit cryptic.
> @@ -1247,8 +1249,10 @@ static const VMStateDescription vmstate_cadence_gem = {
> VMSTATE_UINT32_ARRAY(regs, CadenceGEMState, CADENCE_GEM_MAXREG),
> VMSTATE_UINT16_ARRAY(phy_regs, CadenceGEMState, 32),
> VMSTATE_UINT8(phy_loop, CadenceGEMState),
> - VMSTATE_UINT32(rx_desc_addr, CadenceGEMState),
> - VMSTATE_UINT32(tx_desc_addr, CadenceGEMState),
> + VMSTATE_UINT32_ARRAY(rx_desc_addr, CadenceGEMState,
> + MAX_PRIORITY_QUEUES),
> + VMSTATE_UINT32_ARRAY(tx_desc_addr, CadenceGEMState,
> + MAX_PRIORITY_QUEUES),
> VMSTATE_BOOL_ARRAY(sar_active, CadenceGEMState, 4),
> VMSTATE_END_OF_LIST(),
> }
You need to bump the vmstate version numbers if you change the format.
thanks
-- PMM
