On 18/07/2016 18:57, Sergey Fedorov wrote: > On 18/07/16 19:53, Paolo Bonzini wrote: > > On 18/07/2016 18:52, Sergey Fedorov wrote: > > > So how are we going to use them? > > Instead of atomic_read/atomic_set when marking invalid TBs. > But shouldn't they be atomic to avoid reading torn writes?
A torn write would probably fail to match anyway, but even if it doesn't it is indistinguishable from a race, isn't it? By the way, tb_cmp should also use volatile_read. Paolo
