"Daniel P. Berrange" <[email protected]> writes: > The opts-visitor.c opts_type_bool() method has code for > parsing a string to set a bool value, as does the > qemu-option.c parse_option_bool() method, except it > handles fewer cases. > > To enable consistency across the codebase, extend > parse_option_bool() to handle "yes", "no", "y" and > "n", and make it non-static. Convert the opts > visitor to call this method directly.
Baroque. But you're merely making things consistently baroque. > Also make parse_option_number() non-static to allow > for similar reuse later. > > Reviewed-by: Marc-André Lureau <[email protected]> > Reviewed-by: Eric Blake <[email protected]> > Signed-off-by: Daniel P. Berrange <[email protected]> Reviewed-by: Markus Armbruster <[email protected]>
