On 12 July 2016 at 02:33, Shannon Zhao <[email protected]> wrote: > > > On 2016/7/12 2:22, Peter Maydell wrote: >> Coverity complains that the GICR_IPRIORITYR case in gicv3_readl() >> can overflow an array, because it doesn't know that the offsets >> passed to that function must be word aligned. Add some assert()s >> which hopefully tell Coverity that this isn't possible. >> >> Signed-off-by: Peter Maydell <[email protected]> >> --- >> I don't have any way to test this except getting it into master >> and seeing if Coverity still complains, but if it does then >> I'll happily just mark the error as a false positive... >> > Since the codes are correct, maybe it could ignore the original complain > at Coverity instead of adding the assert(). But anyway I'm fine with > this patch.
Yeah, I was on the fence about just ignoring it. But it's not really feasible for an analysis tool to deduce that the unaligned case can't happen, so a little assistance seemed in order. thanks -- PMM
