On 07/20/10 18:45, Natalia Portillo wrote: > El 20/07/2010, a las 16:17, jes.soren...@redhat.com escribió: > >> From: Jes Sorensen <jes.soren...@redhat.com> >> >> O_DIRECT (cache=none) requires sector alignment, however the physical >> sector size of CDROM/DVD drives is 2048, as opposed to most disk >> devices which use 512. QEMU is hard coding 512 all over the place, so >> allowing O_DIRECT for CDROM/DVD devices does not work. > > What about if the device is a 4096 byte/sector hard disk, a 512 byte/sector > CD-ROM (IRIX ones), a 2048 byte/sector magnetooptical? > > We should get rid of that hard codes and use real values.
I totally agree! However for now my patch throws an error for the CDROM case, which is better than the old situation. We need to fix it in general, but it isn't trivial. The 4096 sector size hard disk going to be the main issue. Jes
