Stefan Hajnoczi writes: > On Tue, Jun 14, 2016 at 03:11:12PM +0200, Lluís Vilanova wrote: >> @@ -1116,6 +1117,7 @@ int main(int argc, char **argv) >> gdbserver_start (gdbstub_port); >> gdb_handlesig(cpu, 0); >> } >> + trace_init_vcpu_events();
> Do vcpu events make sense in *-user builds? I thought this feature is > only available in *-softmmu. It's here for completeness, although it's currently useless. AFAIK, QEMU has multiple vCPUs when the user application is multi-threaded, but user QEMU has no interface to interactively control event states. I can remove it if you want. >> +###################################################################### >> +# Avoid rule overrides when included from multiple top-level variables >> +ifndef MAKEFILE_GUARD_TRACE >> +MAKEFILE_GUARD_TRACE = 1 >> +endif > Are you including this makefile multiple times? We need to find a > cleaner solution. If this is related to "stubs", then could > control-stub.o could go in stubs/? The stubs are the reason, yes. I'll refactor these into the stubs directory. Thanks, Lluis
