Re: [Qemu-devel] [PATCH 12/13] MC146818 RTC: add GPIO access to output IRQ

[Paolo Bonzini]

On 17/06/2016 15:11, Efimov Vasily wrote:
>      qdev_init_nofail(dev);
>      if (intercept_irq) {
> -        s->irq = intercept_irq;
> +        qdev_connect_gpio_out(dev, 0, intercept_irq);
>      } else {
>          isa_init_irq(isadev, &s->irq, RTC_ISA_IRQ);
>      }

Please introduce a wrapper isa_connect_gpio_out so that you can do

    if (intercept_irq) {
        qdev_connect_gpio_out(dev, 0, intercept_irq);
    } else {
        isa_connect_gpio_out(isadev, 0, RTC_ISA_IRQ);
    }

Thanks,

Paolo