On 17.06.2016 08:36, David Gibson wrote: > From: Thomas Huth <[email protected]> > > Since the mac99 and g3beige PowerPC machines recently broke without > being noticed, it would be good to have a tester for "make check" > that detects such issues immediately. A simple way to test the firmware > of these machines is to use the "-prom-env" parameter of QEMU. This > parameter can be used to put some Forth code into the 'boot-command' > firmware variable which then can signal success to the tester by > writing a magic value to a known memory location. And since some of the > Sparc machines are also using OpenBIOS, they are now tested with this > prom-env-tester, too. > > Reviewed-by: Markus Armbruster <[email protected]> > Signed-off-by: Thomas Huth <[email protected]> > [dwg: Removed sparc64, because it trips a TCG bug on 32-bit hosts] > Signed-off-by: David Gibson <[email protected]> > --- > tests/Makefile.include | 6 ++++ > tests/prom-env-test.c | 90 > ++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 96 insertions(+) > create mode 100644 tests/prom-env-test.c > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 6135875..33fcdcb 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -259,6 +259,11 @@ check-qtest-ppc-y += tests/boot-order-test$(EXESUF) > check-qtest-ppc64-y += tests/boot-order-test$(EXESUF) > check-qtest-ppc64-y += tests/spapr-phb-test$(EXESUF) > gcov-files-ppc64-y += ppc64-softmmu/hw/ppc/spapr_pci.c > +check-qtest-ppc-y = tests/prom-env-test$(EXESUF) > +check-qtest-ppc64-y = tests/prom-env-test$(EXESUF) > +check-qtest-sparc-y = tests/prom-env-test$(EXESUF) > +#Disabled for now, triggers a TCG bug on 32-bit hosts > +#check-qtest-sparc64-y = tests/prom-env-test$(EXESUF)
D'Oh! I just realized that there is a stupid copy-n-paste error in these changes: It should be '+=' instead of '=', otherwise the endianness-test for these targets is not run anymore... :-( Sorry! I'll send a fix immediately... Thomas
