On 11 May 2016 at 08:24, Markus Armbruster <arm...@redhat.com> wrote:
> Peter Maydell <peter.mayd...@linaro.org> writes:
>> int qdev_hotplug = 0;
>> @@ -161,6 +162,12 @@ DeviceState *qdev_try_create(BusState *bus, const char
>> *type)
>> }
>>
>> if (!bus) {
>> + /* Assert that the device really is a SysBusDevice before
>> + * we put it onto the sysbus. (Non-sysbus devices which aren't
>> + * being put onto a bus should be created with object_new(TYPE_FOO),
>> + * not qdev_create(NULL, TYPE_FOO).)
>
> Parenthesizing a sentence like this looks odd to me. I'd drop the
> parens.
>
>> + */
>> + g_assert(object_dynamic_cast(OBJECT(dev), TYPE_SYS_BUS_DEVICE) !=
>> NULL);
>
> Long line, easy to fix: drop the redundant != NULL.
>
>> bus = sysbus_get_default();
>> }
>
> Just nits, no respin required. Perhaps they can be addressed on commit.
>
> Reviewed-by: Markus Armbruster <arm...@redhat.com>
Thanks, I have fixed the minor nits and applied this to master.
-- PMM
