Eric Blake <[email protected]> writes: > From: Kővágó, Zoltán <[email protected]>
First posted almost a year ago. I'm glad we're finally ready for this work. Zoltán, I'm sorry it has taken us so long. > This way we no longer need NetClientOptions and can convert Netdev > into a flat union. That's work enabled by this patch, not done by it. We won't actually get rid of NetClientOptions, only confine it to legacy command line support. > Signed-off-by: Kővágó, Zoltán <[email protected]> > Reviewed-by: Eric Blake <[email protected]> > Message-Id: > <93ffdfed7054529635e6acb935150d95dc173a12.1441627176.git.dirty.ice...@gmail.com> > > [rework net_client_init1() to pass Netdev by copying from NetdevLegacy, > rather than merging the two types; rebase to qapi changes] > Signed-off-by: Eric Blake <[email protected]> The patch is mostly mechanical: wherever we replace parameter NetClientOptions *opts by Netdev *netdev, we replace opts by netdev->opts, because netdev wraps opts: struct Netdev { char *id; NetClientOptions *opts; }; The interesting part is the change to net_client_init1(), which looks sane.
