On 13/06/2016 11:36, Peter Maydell wrote: >>> /* The bottom level has pointers to PageDesc */ >>> >> -static void *l1_map[V_L1_SIZE]; >>> >> +static void *l1_map; >> > >> > You can make this array have a static V_L2_SIZE * 16 size too. Peter, >> > what do you think? > I don't know this code well enough to have an informed view, > but we only allocate this once at startup, right? I'm not sure > why making it a static array would be better?
It makes accesses faster by avoiding a pointer load. On one hand it might be just microoptimization, on the other hand... death by one thousand papercuts... Paolo
