On 06/10/2016 09:37 AM, Peter Maydell wrote: > Use stl_le_p() and ldl_le_p() to read and write data from > buffers, rather than using pointer casts and cpu_to_le32() > for writes and le32_to_cpup() for reads. This: > * avoids lots of casts > * works even if the buffer isn't as aligned as the host would like > * avoids using the *_to_cpup() functions which we want to get rid of > > Note that there may still be some places where a pointer from the > guest is cast to a pointer to a host structure; these would also > have to be changed for the device to work on a host CPU which > enforces alignment restrictions. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > hw/usb/dev-network.c | 63 > +++++++++++++++++++++++++--------------------------- > 1 file changed, 30 insertions(+), 33 deletions(-) >
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
