* Peter Maydell ([email protected]) wrote:
> On 10 June 2016 at 12:48, Amit Shah <[email protected]> wrote:
> >
> > The following changes since commit 0c33682d5f29b0a4ae53bdec4c8e52e4fae37b34:
> >
> > target-i386: Move user-mode exception actions out of user-exec.c
> > (2016-06-09 15:55:02 +0100)
> >
> > are available in the git repository at:
> >
> > https://git.kernel.org/pub/scm/virt/qemu/amit/migration.git
> > tags/migration-for-2.7-3
> >
> > for you to fetch changes up to cfac638acf903f7618b285dc3f36de348554c8ad:
> >
> > Postcopy: Check for support when setting the capability (2016-06-10
> > 17:13:32 +0530)
> >
> > ----------------------------------------------------------------
> > Migration:
> >
> > - Fixes for TLS series
> > - Postcopy: Add stats, fix, test case
> >
> > ----------------------------------------------------------------
>
> Fails to build on OSX:
>
> CC tests/postcopy-test.o
> /Users/pm215/src/qemu-for-merges/tests/postcopy-test.c:177:9: error:
> use of undeclared identifier 'got_stop'
> got_stop = true;
> ^
Gah, OK, I see what's happened; it was a fix I did somewhere about v3
I think, after the round where i'd gone allaround the different versions.
I'll retest on both old Linux and mingw.
Dave
> /Users/pm215/src/qemu-for-merges/tests/postcopy-test.c:235:13: error:
> use of undeclared identifier 'got_stop'; did you mean 'vm_stop'?
> if (got_stop || initial_pass) {
> ^~~~~~~~
> vm_stop
> /Users/pm215/src/qemu-for-merges/include/sysemu/sysemu.h:43:5: note:
> 'vm_stop' declared here
> int vm_stop(RunState state);
> ^
> /Users/pm215/src/qemu-for-merges/tests/postcopy-test.c:235:13:
> warning: address of function 'vm_stop' will always evaluate to 'true'
> [-Wpointer-bool-conversion]
> if (got_stop || initial_pass) {
> ^~~~~~~~ ~~
> /Users/pm215/src/qemu-for-merges/tests/postcopy-test.c:235:13: note:
> prefix with the address-of operator to silence this warning
> if (got_stop || initial_pass) {
> ^
> &
> /Users/pm215/src/qemu-for-merges/tests/postcopy-test.c:244:39: error:
> use of undeclared identifier 'got_stop'; did you mean 'vm_stop'?
> } while (pass == initial_pass && !got_stop);
> ^~~~~~~~
> vm_stop
> /Users/pm215/src/qemu-for-merges/include/sysemu/sysemu.h:43:5: note:
> 'vm_stop' declared here
> int vm_stop(RunState state);
> ^
> /Users/pm215/src/qemu-for-merges/tests/postcopy-test.c:244:39:
> warning: address of function 'vm_stop' will always evaluate to 'true'
> [-Wpointer-bool-conversion]
> } while (pass == initial_pass && !got_stop);
> ~^~~~~~~~
> /Users/pm215/src/qemu-for-merges/tests/postcopy-test.c:244:39: note:
> prefix with the address-of operator to silence this warning
> } while (pass == initial_pass && !got_stop);
> ^
> &
> /Users/pm215/src/qemu-for-merges/tests/postcopy-test.c:262:33: error:
> use of undeclared identifier 'start_address'
> qtest_memread(global_qtest, start_address, &first_byte, 1);
> ^
> /Users/pm215/src/qemu-for-merges/tests/postcopy-test.c:265:20: error:
> use of undeclared identifier 'start_address'
> for (address = start_address + 4096; address < end_address; address +=
> 4096)
> ^
> /Users/pm215/src/qemu-for-merges/tests/postcopy-test.c:265:52: error:
> use of undeclared identifier 'end_address'
> for (address = start_address + 4096; address < end_address; address +=
> 4096)
> ^
> /Users/pm215/src/qemu-for-merges/tests/postcopy-test.c:307:5: error:
> use of undeclared identifier 'got_stop'
> got_stop = false;
> ^
> /Users/pm215/src/qemu-for-merges/tests/postcopy-test.c:380:10: error:
> use of undeclared identifier 'got_stop'; did you mean 'vm_stop'?
> if (!got_stop) {
> ^~~~~~~~
> vm_stop
> /Users/pm215/src/qemu-for-merges/include/sysemu/sysemu.h:43:5: note:
> 'vm_stop' declared here
> int vm_stop(RunState state);
> ^
> /Users/pm215/src/qemu-for-merges/tests/postcopy-test.c:380:10:
> warning: address of function 'vm_stop' will always evaluate to 'true'
> [-Wpointer-bool-conversion]
> if (!got_stop) {
> ~^~~~~~~~
> /Users/pm215/src/qemu-for-merges/tests/postcopy-test.c:380:10: note:
> prefix with the address-of operator to silence this warning
> if (!got_stop) {
> ^
> &
> /Users/pm215/src/qemu-for-merges/tests/postcopy-test.c:395:23: error:
> use of undeclared identifier 'start_address'
> qtest_memread(to, start_address, &dest_byte_a, 1);
> ^
> /Users/pm215/src/qemu-for-merges/tests/postcopy-test.c:399:27: error:
> use of undeclared identifier 'start_address'
> qtest_memread(to, start_address, &dest_byte_b, 1);
> ^
> /Users/pm215/src/qemu-for-merges/tests/postcopy-test.c:405:23: error:
> use of undeclared identifier 'start_address'
> qtest_memread(to, start_address, &dest_byte_c, 1);
> ^
> /Users/pm215/src/qemu-for-merges/tests/postcopy-test.c:407:23: error:
> use of undeclared identifier 'start_address'
> qtest_memread(to, start_address, &dest_byte_d, 1);
> ^
> 3 warnings and 12 errors generated.
>
>
> thanks
> -- PMM
--
Dr. David Alan Gilbert / [email protected] / Manchester, UK
