On 03/06/2016 09:04, Gerd Hoffmann wrote:
> static void set_pixel_format(VncState *vs,
> int bits_per_pixel, int depth,
> int big_endian_flag, int true_color_flag,
> @@ -2101,8 +2119,15 @@ static void set_pixel_format(VncState *vs,
> int red_shift, int green_shift, int blue_shift)
> {
> if (!true_color_flag) {
> - vnc_client_error(vs);
> - return;
> + /* Expose a reasonable default 256 color map */
> + bits_per_pixel = 8;
> + depth = 8;
> + red_max = 7;
> + green_max = 7;
> + blue_max = 3;
> + red_shift = 0;
> + green_shift = 3;
> + blue_shift = 6;
> }
Coverity now notes that the "depth" argument is unused.
It's not introduced by this patch, but now it notices because this hunk
introduces a dead write.
Thanks,
Paolo
