On 2 June 2016 at 16:45, Laurent Vivier <[email protected]> wrote: > Le 02/06/2016 à 17:39, Peter Maydell a écrit : >> I don't think we need a command line switch for this -- we should only >> have those for cases where there's a reasonable user decision to >> say "I don't want feature X (even if my host might support it)". >> For this kind of thing we should just have a configure test for >> "do the host headers support feature X" and unconditionally use it >> if present. That's what we do for things like CONFIG_FIEMAP, for instance. > > ok, but in this case what is the best solution: > 1- to check the host environment in configure and define (or not) a > CONFIG_NETLINK, > 2- Add a "#ifdef IFLA_PROTO_DOWN" directly in the code?
I don't have a strong preference. thanks -- PMM
