On 05/23/2016 09:42 AM, Kevin Wolf wrote: > Am 06.05.2016 um 18:26 hat Eric Blake geschrieben: >> Sector-based blk_write() should die; convert the one-off >> variant blk_write_zeroes() to use an offset/count interface >> instead. Likewise for blk_co_write_zeroes() and >> blk_aio_write_zeroes(). >> >> Signed-off-by: Eric Blake <[email protected]> > > You built a nice trap here: bdrv_*write_zeroes() is still sector based > whereas blk_*write_zeroes() changed to be byte based without a rename. > That broke my block jobs series which converts from bdrv_* to blk_* > after the next (seemingly clean) rebase. > > I fixed my series now, but can we please convert bdrv_* as well > before we get more victims in the same trap? Also (and perhaps more > importantly) we could rename the functions to something like > blk_*pwrite_zeroes(), indicating the switch to byte based.
Sure, the rename idea makes sense. I should have something posted later today. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
