Re: [Qemu-devel] [PULL v2 16/17] gtk: update grab code for gtk 3.20

[Paolo Bonzini]

On 13/05/2016 14:32, Gerd Hoffmann wrote:
> @@ -1442,14 +1474,19 @@ static void gd_grab_pointer(VirtualConsole *vc, const 
> char *reason)
>  static void gd_ungrab_pointer(GtkDisplayState *s)
>  {
>      VirtualConsole *vc = s->ptr_owner;
> +    GdkDisplay *display = gtk_widget_get_display(vc->gfx.drawing_area);
>  
>      if (vc == NULL) {
>          return;
>      }

Unnecessary vc == NULL check, or possible NULL pointer dereference in
the assignment to display?  (Spotted by Coverity).

Thanks,

Paolo

>      s->ptr_owner = NULL;
>  
> -    GdkDisplay *display = gtk_widget_get_display(vc->gfx.drawing_area);