Re: [Qemu-devel] [PATCH v3 2/4] hw/char: QOM'ify etraxfs_ser.c

[xiaoqiang zhao]

在 2016年05月17日 20:51, Paolo Bonzini 写道:

I'm sorry, this is not enough.  You need to learn how to test this
device.  CRIS images are available athttp://wiki.qemu.org/Testing.

You have not added a replacement for the call to
qemu_char_get_next_serial().  The board code in hw/cris/axis_dev88.c
needs to use qemu_char_get_next_serial().

I suggest creating a function like

     void etraxfs_ser_create(hwaddr addr, qemu_irq irq,
                             CharDriverState *chr) {
         DeviceState *dev;
         SysBusDevice *s;
         qemu_irq irq;

         dev = qdev_create(NULL, "extrafs,serial");
         s = SYS_BUS_DEVICE(dev);
         qdev_prop_set_chr(s, "chardev", chr);
         qdev_init_nofail(dev);
         sysbus_mmio_map(s, 0, addr);
         sysbus_connect_irq(s, 0, irq);
     }

 Oh, I see.