Huacai Chen <zltjiang...@gmail.com> wrote: > Signed-off-by: Huacai Chen <zltjiang...@gmail.com> > --- > hw/usb-uhci.c | 29 +++++++++++++++++++++++++++++ > hw/usb-uhci.h | 1 + > 2 files changed, 30 insertions(+), 0 deletions(-) > > diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c > index 624d55b..accfe2e 100644 > --- a/hw/usb-uhci.c > +++ b/hw/usb-uhci.c > @@ -1149,6 +1149,25 @@ static int usb_uhci_piix4_initfn(PCIDevice *dev) > > pci_config_set_vendor_id(pci_conf, PCI_VENDOR_ID_INTEL); > pci_config_set_device_id(pci_conf, PCI_DEVICE_ID_INTEL_82371AB_2); > + pci_set_byte(pci_conf + PCI_LATENCY_TIMER, 0x16); > + > + /* USB misc control 1/2 */ > + pci_set_long(pci_conf + 0x40,0x00001000); > + /* PM capability */ > + pci_set_long(pci_conf + 0x80,0x00020001); > + /* USB legacy support */ > + pci_set_long(pci_conf + 0xc0,0x00002000);
This looks fishy. You are adding fields to uhci_piix4 when adding via usb controller? If this fields are needed for piix4 (I don't know) they should be split in its own patch, no?
