On 12/05/2016 19:04, Eduardo Habkost wrote: >>> This changes some initialization code in vl.c, qemu-img, qemu-io, >>> > > and qemu-nbd to use &error_fatal instead of manual error >>> > > checking/reporting. >>> > > >>> > > The series is based on my machine branch, available at: >>> > > git://github.com/ehabkost/qemu.git machine >> > >> > Patches 1-2-6 are obvious. > Thanks. I will apply 1-2 to my machine branch. Should I apply > patch 6, too?
Yes, please. >> > I'm not sure about 3-4-5, these are internal functions where the error >> > is somewhere below "should never happen" (&error_abort)---it actually >> > should never happen, but exiting due to SIGABRT sounds wrong. It's not >> > the kind of function that I'd expect to have an Error** argument... > Assuming you still want to keep the Error** argument in > qemu_init_main_loop(), I can send a simpler patch that doesn't > touch qemu_signal_init(). Sure, that's good! Paolo
