>>> On 5/10/2016 at 12:48 AM, Eric Blake <[email protected]> wrote:
> On 05/07/2016 05:32 PM, Nan Li wrote:
>> Add a "fuse-mount" command to support the Filesystem in Userspace (FUSE).
>> It can mount or unmount the filesystem with both hmp and qmp commands.
>> It calls the API function qemu_fuse_main(int argc, char *argv[]).
>>
>> Signed-off-by: Nan Li <[email protected]>
>> ---
>> +++ b/qapi-schema.json
>> @@ -2283,6 +2283,21 @@
>> 'returns': 'DumpGuestMemoryCapability' }
>>
>> ##
>> +# @fuse-mount:
>> +#
>> +# mount(unmount) fuse system on 'mountpoint'.
>> +#
>> +# @is_mount: optional if true, umount the fuse system from the mount point
>
> s/umount/unmount/
>
> New QMP commands should favor the use of '-' rather than '_' (as in
> 'is-mount'). But the name 'is_mount' does not even appear below, so you
> aren't documenting reality.
>
Right. This parameter should be unmount.
>> +#
>> +# @mountpoint: the mount point (a path) of fuse system
>> +#
>> +# Returns: Nothing on success
>> +#
>> +# Since: 2.6
>
> You've missed 2.6. This has to be 2.7 or later.
>
OK. Thanks for pointing it out.
>> +##
>> +{ 'command': 'fuse-mount', 'data': {'unmount': 'bool', 'mountpoint': 'str'}
> }
>> +
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
Nan Li
