On 05/04/2016 07:54 AM, Markus Armbruster wrote:
> Uh, in visitor.h at the end of this series:
>
> * <example>
> * Visitor *v;
> * Error *err = NULL;
> * int value;
> *
> * v = ...obtain visitor...
> * visit_start_struct(v, NULL, NULL, 0, &err);
> * if (err) {
> ---> goto outobj;> * outobj: > * visit_end_struct(v); > * error_propagate(errp, err); > * ...clean up v... > * </example> > > The ---> goto is wrong; we call visit_end_struct() after > visit_start_struct() failed. Haven't dug through the patches to find > the guilty one. > Fairly easy fix, and only affects doc (patch 12/24 introduced it). I've sent a fixup that you can squash in, since qapi-next is not merged to master yet. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
