On Fri 29 Apr 2016 04:38:58 PM CEST, Kevin Wolf wrote: > This is essentially the same as I'm doing here: > http://repo.or.cz/qemu/kevin.git/commitdiff/6b545b21e3dfe2e3927cfb6bbdcc1b233c67630c
Oh, I see. > I think I like having a separate block_job_cancel_sync_all() function > like I did instead of inlining it in bdrv_close_all(), though that's a > matter of taste. Having a separate function looks good, but I don't really have a strong opinion on this. Berto
