Re: [Qemu-devel] [PATCH QEMU 3/5] virtio-balloon: Add a new feature to balloon device

[Michael S. Tsirkin]

On Tue, Apr 19, 2016 at 10:20:41PM +0800, Liang Li wrote:
> +    if (s->req_status == REQ_INIT) {
> +        s->free_page_bmap = bitmap;
> +        if (elem == NULL || !elem->in_num) {
> +            elem = virtqueue_pop(s->fvq, sizeof(VirtQueueElement));
> +            if (!elem) {
> +                return FREE_PAGE_ERROR;
> +            }
> +            s->free_page_vq_elem = elem;
> +        }
> +        s->free_page_req.param = drop_cache_ctl;

Dropping cache should probably be a separate request -
seems independently useful.

-- 
MST