On Sun, Feb 21, 2016 at 01:05:24PM +0200, Marcel Apfelbaum wrote:
[...]
> > static void
> > build_dmar_q35(GArray *table_data, GArray *linker)
> > {
> >@@ -2496,10 +2509,19 @@ build_dmar_q35(GArray *table_data, GArray *linker)
> >
> > AcpiTableDmar *dmar;
> > AcpiDmarHardwareUnit *drhd;
> >+ uint8_t dmar_flags = 0;
> >+ IntelIOMMUState *intel_iommu = acpi_get_iommu();
> >+
> >+ assert(intel_iommu);
> >+
> >+ if (intel_iommu->intr_supported) {
>
> Hi,
>
> It seems intr_supported duplicates the same field you have in machine.
> You can pass the machine to build_dmar_q35 and get rid of the extra field.
You are right. Will drop intr_supported in all the patches.
Thanks.
-- peterx
