On 01/04/2016 05:52, David Gibson wrote:
> This seems like the right minimal fix in the qemu-2.6 timeframe to fix
> the actual bug. However, longer term it seems like the correct thing
> to do might be to set kvm_vcpu_dirty early in the reset path. Thoughts?
Isn't it done already? vl.c does:
pause_all_vcpus();
cpu_synchronize_all_states();
qemu_system_reset(VMRESET_REPORT);
resume_all_vcpus();
Thanks,
Paolo
> diff --git a/target-ppc/mmu-hash64.c b/target-ppc/mmu-hash64.c
> index 72c4ab5..caf41ce 100644
> --- a/target-ppc/mmu-hash64.c
> +++ b/target-ppc/mmu-hash64.c
> @@ -283,8 +283,6 @@ void ppc_hash64_set_external_hpt(PowerPCCPU *cpu, void
> *hpt, int shift,
> CPUPPCState *env = &cpu->env;
> Error *local_err = NULL;
>
> - cpu_synchronize_state(CPU(cpu));
> -
> if (hpt) {
> env->external_htab = hpt;
> } else {
