On 29.03.2016 15:30, Kevin Wolf wrote: > We must forbid changing the WCE flag in bdrv_reopen() in the same patch, > as otherwise the behaviour would change so that the flag takes > precedence over the explicitly specified option. > > The correct value of the WCE flag depends on the BlockBackend user (e.g. > guest device) and isn't a decision that the QMP client makes, so this > change is what we want. > > Signed-off-by: Kevin Wolf <[email protected]> > --- > block.c | 18 ++++++------------ > qemu-io-cmds.c | 14 +++++++++++++- > tests/qemu-iotests/142 | 2 +- > tests/qemu-iotests/142.out | 2 +- > 4 files changed, 21 insertions(+), 15 deletions(-)
Reviewed-by: Max Reitz <[email protected]> For some weird reason I thought that blk_enable_write_cache() always returned true here. Which is not true, of course. Max
signature.asc
Description: OpenPGP digital signature
