Le 23/03/2016 15:48, Peter Maydell a écrit :
On 19 March 2016 at 20:59, Jean-Christophe Dubois <[email protected]> wrote:
The sabrelite supports one SPI FLASH memory on SPI1

Signed-off-by: Jean-Christophe Dubois <[email protected]>
+    {
+        /* Add the sst25vf016b NOR FLASH memory to first SPI */
+        Object *spi_dev;
+
+        spi_dev = object_resolve_path_component(OBJECT(&s->soc), "spi1");
Can you add a comment to remind us there's a todo here:
  /* Ideally we would expose the chip select and spi bus on the SoC
   * object using alias properties; then we would not need to directly
   * access the underlying spi device object.
   */
OK

Otherwise
Reviewed-by: Peter Maydell <[email protected]>

thanks
-- PMM



Reply via email to