On Thu, Mar 03, 2016 at 07:34:21AM +0100, Markus Armbruster wrote: > Peter Xu <[email protected]> writes: > > I see that qapi-introspect branch is not there now. Is it merged to > > some other branch already? When will it be there in QEMU master > > (still not in, right?)? Just curious about it. > > Merged in commit 9e72681. > > Between the talk and the merge, query-schema got renamed to > query-qmp-schema. Sometimes I relapse. Sorry for the confusion!
Got it! > > Now I can understand. For this case, I guess both ways work, right? > > Considering that if "query-schema" is still not there, I'd still > > prefer the "array" solution. At least, it can keep the schema > > several lines shorter (as you have mentioned already, it's *big* > > enough :). Also, even we would have "query-schema", I would still > > prefer not change schema unless necessary. What do you think? > > I can't say without understanding what the introspection question would > be. That needs actual thought, which is in short supply, especially > before breakfast ;) Yah, anyway, looking forward to further review comments! For now, maybe I can start to work on v2 if no big problem. If there is better way, v3 is ready to go. :) Peter
