On 03/02/2016 10:15 AM, Markus Armbruster wrote: > Eric Blake <ebl...@redhat.com> writes: > >> C types and JSON objects don't have fields, but members. We >> shouldn't gratuitously invent terminology. This patch is a >> strict renaming of generator code and static genarated functions, >> plus the naming of the dummy filler member for empty structs, >> before the next patch exposes some of that naming to the rest of >> the code base. >> >> Suggested-by: Markus Armbruster <arm...@redhat.com> >> Signed-off-by: Eric Blake <ebl...@redhat.com> >> >> --- >> v2: new patch > > Patch looks good. You could split it into Python renames (no change to > generated code) and C renames. Only if you like the idea.
Sure, not too much work. > > If you want to be *really* thorough: there's a "field" left in > tests/qapi-schema/qapi-schema-test.json, and a few in > docs/qapi-code-gen.txt. I'll save docs/ for 3/19, but get the .json file fixed along with the Python renames. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
