On Fri, Feb 19, 2016 at 05:19:35PM -0700, Eric Blake wrote: > qapi code generators currently create a 'void *data' member as > part of the anonymous union embedded in the C struct corresponding > to a qapi union. However, directly assigning to this member of > the union feels a bit fishy, when we can directly use the rest > of the struct instead. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > > --- > v1: no change > Previously posted as part of qapi cleanup series F: > v6: rebase to latest > --- > blockdev.c | 31 +++++++++++++++++-------------- > ui/input.c | 2 +- > 2 files changed, 18 insertions(+), 15 deletions(-)
Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
