On Mon, Jan 11, 2016 at 07:32:32AM -0600, [email protected] wrote: > From: Corey Minyard <[email protected]> > > It was falling through when it should have been a break. Found by > Coverity. The logic could be simplified a bit with a fallthrough, > probably the original thought, but that would be less clear, I think. > > Cc: Paolo Bonzini <[email protected]> > Cc: Michael S. Tsirkin <[email protected]> > Cc: Peter Maydell <[email protected]> > Cc: Shannon Zhao <[email protected]> > Cc: Xiao Guangrong <[email protected]> > Cc: Stefan Hajnoczi <[email protected]> > Signed-off-by: Corey Minyard <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]> > --- > hw/ipmi/ipmi_bmc_sim.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c > index 3ecf02e..e522ffa 100644 > --- a/hw/ipmi/ipmi_bmc_sim.c > +++ b/hw/ipmi/ipmi_bmc_sim.c > @@ -1101,6 +1101,8 @@ static void set_watchdog_timer(IPMIBmcSim *ibs, > rsp[2] = IPMI_CC_INVALID_DATA_FIELD; > goto out; > } > + break; > + > default: > /* We don't support PRE_SMI */ > rsp[2] = IPMI_CC_INVALID_DATA_FIELD; > -- > 2.5.0
