On Feb 2, 2016, at 11:36 PM, Eric Blake wrote:
> On 02/02/2016 09:21 PM, Programmingkid wrote:
>
>>>> #if defined(__APPLE__) && defined(__MACH__)
>>>> /* if a physical device experienced an error while being opened */
>>>> if (strncmp((*bsd_path ? bsd_path : filename), "/dev/", 5) == 0) {
>>>> print_unmounting_directions(*bsd_path ? bsd_path : filename);
>>>> return -1;
>>>> }
>>>
>>> A bit repetitive. You don't use filename after the fact, so shorter
>>> would be:
>>>
>>> #if defined(__APPLE__)...
>>> if (*bsd_path) {
>>> filename = filename;
>
> Oops, I shouldn't be writing emails late at night. Let's try this again.
>
> if (*bsd_path) {
> filename = bsd_path;
> }
> if (strncmp(filename, ...
>
> Hopefully that makes more sense.
So you want this:
#if defined(__APPLE__) && defined(__MACH__)
if (*bsd_path) {
filename = bsd_path;
}
/* if a physical device experienced an error while being opened */
if (strncmp(filename, "/dev/", 5) == 0) {
print_unmounting_directions(filename);
return -1;
}
#endif /* defined(__APPLE__) && defined(__MACH__) */
