Eric Blake <[email protected]> writes: > Based on qemu.git master. Pending prerequisites: > + Not a strong dependency, but for qapi-tests to consistently pass, > I needed a race fixed: > https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg01827.html > > Also available as a tag at this location: > git fetch git://repo.or.cz/qemu/ericb.git qapi-cleanupv8e > > and will soon be part of my branch with the rest of the v5 series, at: > http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi > > v8 notes: > Four new patches (13-16/35), plus rebasing on top of them, so that > the code base now consistently passes a 'v, name' pair anywhere a > visitor needs a name, rather than putting other arguments in between > the pair. I got to have fun with Coccinelle :) Also fix a bug in my > changes to visit_next_list() (v7 29/31), so that 'make check' and > qemu-iotests now pass at all points in the series. > > The parameter ordering changes have the potential to be a rebase > magnet, so I'm hoping this series can go in relatively soon after > Markus returns from break. > > I made good on my threat in v7 of writing a qapi-to-JSON output > visitor, but that will remain a separate series based on this one > (the only posting of that series so far now needs rebasing: > https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg01760.html) > > 001/35:[----] [--] 'qobject: Document more shortcomings in our number > handling' > 002/35:[----] [--] 'qapi: Avoid use of misnamed DO_UPCAST()' > 003/35:[----] [--] 'qapi: Drop dead dealloc visitor variable' > 004/35:[----] [--] 'hmp: Improve use of qapi visitor' > 005/35:[----] [--] 'vl: Improve use of qapi visitor' > 006/35:[----] [--] 'balloon: Improve use of qapi visitor' > 007/35:[----] [--] 'qapi: Improve generated event use of qapi visitor' > 008/35:[----] [--] 'qapi: Track all failures between visit_start/stop' > 009/35:[----] [--] 'qapi: Prefer type_int64 over type_int in visitors' > 010/35:[----] [--] 'qapi: Make all visitors supply uint64 callbacks' > 011/35:[----] [--] 'qapi: Consolidate visitor small integer callbacks' > 012/35:[----] [--] 'qapi: Don't cast Enum* to int*' > 013/35:[down] 'qom: Use typedef for Visitor'
Applies cleanly until here. > 014/35:[down] 'qapi: Swap visit_* arguments for consistent 'name' placement' Doesn't apply. You can either spin v9 addressing Marc-André's review, or you can rebase v8 without changes somewhere I can pull, so I can review it properly. [...]
